Local apps: add MLX LM #1443
Merged
Local apps: add MLX LM #1443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-c
reviewed
May 9, 2025
There was a problem hiding this comment.
(maybe let's add it as a local app and change the library snippets to python?)
yes, i think that's what we should do:
- (modeling) libraries are for actual code snippets, including in Python
- local apps are for CLIs
That's consistent with what we've done for llama.cpp:
llama.cpp and node-llama-cpp are apps
whereas llama-cpp-python is a "library"
gary149
requested review from
SBrandeis,
Wauplin,
pcuenca and
ngxson
as code owners
pcuenca
approved these changes
May 12, 2025
|
cc @Vaibhavs10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still hesitating between this (adding it as a local app) and updating the libraries snippets directly wdyt @pcuenca ? (maybe let's add it as a local app and change the library snippets to python?)